Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pin @octokit/core peerDependency to v5 #720

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

DanCurryy
Copy link

Resolves #717


Before the change?

  • Octokit/core@6 is now ESM, which while this version is still CJS can't pull in and use.

After the change?

  • Pinning this back to Octokit/core@5 where it remains CJS fixes this.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title Pin @octokit/core peerDependency to v5 fix(deps): pin @octokit/core peerDependency to v5 Mar 1, 2024
@wolfy1339
Copy link
Member

@gr2m @nickfloyd The branch protection rules aren't valid for this branch. I feel like it's matching some generic v*.* matcher and including some workflows that haven't been here for a while

@kfcampbell
Copy link
Member

@wolfy1339 I've removed the invalid branch protection checks for the *.x branch protection rule. There are some other 1.x through 6.x rules as well, but hopefully those are far enough back in history they won't be relevant for us. Please let me know if you'd like more changes here!

@wolfy1339 wolfy1339 merged commit 8ea26f4 into octokit:10.x Mar 1, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 10.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants